[delta-audit] bonding: Various fixes from audit findings #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
force-pushed
the
vg/fix/audit
branch
from
5f9f84e
to
ca3f5bb
Compare
victorges
force-pushed
the
vg/fix/audit
branch
2 times, most recently
from
429b877
to
427a77e
Compare
victorges
changed the title
victorges
changed the title
victorges
force-pushed
the
vg/fix/audit
branch
from
427a77e
to
287ce31
Compare
victorges
force-pushed
the
vg/fix/audit
branch
from
72c6a2f
to
6dee962
Compare
We've had some many wardens spending their time auditing this function and the side-effects of it, when it is disabled and so doesn't really matter. Adding the comment so we don't need to remember on the next audit to make this disclaimer.
victorges
added a commit
that referenced
this pull request
Sep 27, 2023
* Add remappings file for vs code * bonding: Avoid double-checkpoint on self-bond/unbond * bonding: Fix solidity version for IBondingVotes * bonding: Add lastClaimRound to delegator change event * bonding,treasury: Fix a few documentations QA Report code-423n4/2023-08-livepeer-findings#150 * bonding: Improve docs about unused _endRound Reported on: code-423n4/2023-08-livepeer-findings#205 * bonding: Address PR comments * bonding: Add deprecation notice to slashTranscoder We've had some many wardens spending their time auditing this function and the side-effects of it, when it is disabled and so doesn't really matter. Adding the comment so we don't need to remember on the next audit to make this disclaimer.
victorges
added a commit
that referenced
this pull request
Oct 11, 2023
* Add remappings file for vs code * bonding: Avoid double-checkpoint on self-bond/unbond * bonding: Fix solidity version for IBondingVotes * bonding: Add lastClaimRound to delegator change event * bonding,treasury: Fix a few documentations QA Report code-423n4/2023-08-livepeer-findings#150 * bonding: Improve docs about unused _endRound Reported on: code-423n4/2023-08-livepeer-findings#205 * bonding: Address PR comments * bonding: Add deprecation notice to slashTranscoder We've had some many wardens spending their time auditing this function and the side-effects of it, when it is disabled and so doesn't really matter. Adding the comment so we don't need to remember on the next audit to make this disclaimer.
victorges
added a commit
that referenced
this pull request
Oct 11, 2023
* Add remappings file for vs code * bonding: Avoid double-checkpoint on self-bond/unbond * bonding: Fix solidity version for IBondingVotes * bonding: Add lastClaimRound to delegator change event * bonding,treasury: Fix a few documentations QA Report code-423n4/2023-08-livepeer-findings#150 * bonding: Improve docs about unused _endRound Reported on: code-423n4/2023-08-livepeer-findings#205 * bonding: Address PR comments * bonding: Add deprecation notice to slashTranscoder We've had some many wardens spending their time auditing this function and the side-effects of it, when it is disabled and so doesn't really matter. Adding the comment so we don't need to remember on the next audit to make this disclaimer.
victorges
added a commit
that referenced
this pull request
Oct 11, 2023
* Add remappings file for vs code * bonding: Avoid double-checkpoint on self-bond/unbond * bonding: Fix solidity version for IBondingVotes * bonding: Add lastClaimRound to delegator change event * bonding,treasury: Fix a few documentations QA Report code-423n4/2023-08-livepeer-findings#150 * bonding: Improve docs about unused _endRound Reported on: code-423n4/2023-08-livepeer-findings#205 * bonding: Address PR comments * bonding: Add deprecation notice to slashTranscoder We've had some many wardens spending their time auditing this function and the side-effects of it, when it is disabled and so doesn't really matter. Adding the comment so we don't need to remember on the next audit to make this disclaimer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This mitigates a couple minor findings from the audit that either haven't been flagged by wardens but we found through self-review (e.g. duplicate checkpoints) or too minor issue to have its own PR (solidity version). Even though I'm combining all the fixes in this PR, each mitigation is done on a separate commit to facilitate review.
Specific updates (required)
previous/newLastClaimRoundto theDelegatorBondedAmountChangedevent (otherwise some changes would be silent on the event side, like unbonding exactly the amount of pending rewards)The minorest:
IBondingVotes.solfileremappings.txtfile to the project, which improves VS Code suggestions and navigationHow did you test each of these updates (required)
Added tests to all the functional changes and
yarn testWill deploy on devnet after merged.
Does this pull request close any open issues?
N/A
Checklist:
yarn testpass