[delta-audit] bonding: Only provide voting power for active stake #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
force-pushed
the
vg/fix/total-supply-invariant
branch
2 times, most recently
from
5611e8c
to
38e7a9e
Compare
victorges
changed the title
victorges
force-pushed
the
vg/fix/total-supply-invariant
branch
from
38e7a9e
to
b970652
Compare
victorges
force-pushed
the
vg/fix/total-supply-invariant
branch
from
b970652
to
bf7ba8b
Compare
victorges
force-pushed
the
vg/fix/total-supply-invariant
branch
2 times, most recently
from
42b1a70
to
f6cfad1
Compare
victorges
changed the title
victorges
changed the title
victorges
changed the title
|
we're going with #625 for now. this can be reopen in the future as a separate improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to fix the
totalSupply = sum(getVotes(*))invariant fromBondingVotes,which wasn't held before when we provided voting power to both active and inactive
transcoders and their delegators.
With this change, we make sure the transcoder active stake is also taken into account
and provide zero voting power when the transcoder is not active.
Specific updates (required)
isActiveTranscoderbool, derived from activation and deactivation roundsHow did you test each of these updates (required)
yarn testDoes this pull request close any open issues?
Fixes PRO-39
Also ended up being a potential fix for code-423n4/2023-08-livepeer-findings#194
Checklist:
yarn testpass