Skip to content

Commit

Permalink
deploy: Allow only governor to execute treasury proposals
Browse files Browse the repository at this point in the history
The Governor already exposes an execute() function that
will call the timelock (treasury) internally, so we don't
need to expose the treasury directly to calls by anyone.
  • Loading branch information
victorges committed Oct 6, 2023
1 parent d3cb971 commit ff30c77
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions deploy/deploy_contracts.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {HardhatRuntimeEnvironment} from "hardhat/types"
import {DeployFunction} from "hardhat-deploy/types"
import {ethers} from "hardhat"
import {Contract, constants} from "ethers"
import {Contract} from "ethers"
import {DeployResult, Export} from "hardhat-deploy/dist/types"
import fs from "fs"

Expand Down Expand Up @@ -303,7 +303,7 @@ const func: DeployFunction = async function(hre: HardhatRuntimeEnvironment) {
await Treasury.initialize(
config.treasury.minDelay,
[], // governor will be added as a proposer later
[constants.AddressZero], // let anyone execute proposals
[], // governor will be added as an executor later
deployer // temporary admin role for deployer
).then(tx => tx.wait())

Expand Down
2 changes: 1 addition & 1 deletion deploy/deploy_delta_upgrade.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const func: DeployFunction = async function(hre: HardhatRuntimeEnvironment) {
await Treasury.initialize(
config.treasury.minDelay,
[], // governor will be added as a proposer later
[ethers.constants.AddressZero], // let anyone execute proposals
[], // governor will be added as an executor later
deployer // temporary admin role for deployer
).then(tx => tx.wait())

Expand Down

0 comments on commit ff30c77

Please sign in to comment.