Transfer participant integration test #186
Open
+354
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
approved these changes
Oct 2, 2024
Comment on lines
+412
to
+422
| require.Equal(t, sipgo.REFER, referRequest.Method) | ||
| transferTo := referRequest.GetHeader("Refer-To") | ||
| require.Equal(t, "tel:"+transferNumber, transferTo.Value()) | ||
|
|
||
| time.Sleep(notifyIntervalDelay) | ||
| err = cli.SendNotify(referRequest, "SIP/2.0 100 Trying") | ||
| require.NoError(t, err) | ||
|
|
||
| time.Sleep(notifyIntervalDelay) | ||
| err = cli.SendNotify(referRequest, "SIP/2.0 200 OK") | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
This part could be in onRefer callback, then there will be no need for a mutex and shared variable (referRequest). Same for the second test.
| _, err = lk.SIP.TransferSIPParticipant(context.Background(), &livekit.TransferSIPParticipantRequest{ | ||
| RoomName: "test-open", | ||
| ParticipantIdentity: "sip_" + clientNumber, | ||
| TransferTo: "tel:" + transferNumber, |
There was a problem hiding this comment.
Would be nice to also see if we can properly refer for outbound. But that can be done separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes sure that we do not cancel the transfer request if the RPC handler gets cancelled, and avoids situation where we may return an old transfer result to a 2nd transfer request if one failed before.