Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inbound media processors #185

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Add inbound media processors #185

merged 10 commits into from
Oct 3, 2024

Conversation

frostbyte73
Copy link
Member

No description provided.

@frostbyte73 frostbyte73 requested a review from a team as a code owner September 26, 2024 20:48
pkg/media/processor.go Outdated Show resolved Hide resolved
pkg/sip/server.go Outdated Show resolved Hide resolved
pkg/sip/inbound.go Outdated Show resolved Hide resolved
pkg/sip/inbound.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.98%. Comparing base (c7fd4ad) to head (ae9fb2a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sip/media_port.go 20.00% 3 Missing and 1 partial ⚠️
pkg/service/psrpc.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   66.24%   62.98%   -3.27%     
==========================================
  Files          50       50              
  Lines        5659     6170     +511     
==========================================
+ Hits         3749     3886     +137     
- Misses       1576     1943     +367     
- Partials      334      341       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You could add it now for outbound pretty easily, I think. Or could be another PR.

@frostbyte73 frostbyte73 merged commit 49e84c7 into main Oct 3, 2024
3 checks passed
@frostbyte73 frostbyte73 deleted the processors branch October 3, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants