Fix race when playing dial tones. (#228)

(cherry picked from commit 44fe89c)
livekit · Nov 18, 2024 · 1c22c9a · 1c22c9a
1 parent 4b0b3cb
commit 1c22c9a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/pkg/sip/outbound.go b/pkg/sip/outbound.go
@@ -274,7 +274,13 @@ func (c *outboundCall) dialSIP(ctx context.Context) error {
 		go func() {
 			rctx, span := tracer.Start(rctx, "tones.Play")
 			defer span.End()
-			tones.Play(rctx, c.lkRoomIn, ringVolume, tones.ETSIRinging)
+			c.mu.RLock()
+			dst := c.lkRoomIn
+			c.mu.RUnlock()
+			if dst == nil {
+				return
+			}
+			tones.Play(rctx, dst, ringVolume, tones.ETSIRinging)
 		}()
 	}
 	err := c.sipSignal(ctx)