rtc: bump ffi to v0.10.2 #271
Open
+205
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 23511a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
theomonnom
approved these changes
Sep 18, 2024
|
@theomonnom can you re-check? want to make sure i did this impl correctly |
theomonnom
reviewed
Sep 19, 2024
theomonnom
reviewed
Sep 19, 2024
| import EventEmitter, { once } from 'events'; | ||
|
|
||
| /** @internal */ | ||
| export class Queue<T> { |
There was a problem hiding this comment.
Seems like the Queue isn't needed, just Promise/Future for this impl? not a big deal either way
There was a problem hiding this comment.
this promise is reused more than one time so it's more ergonomic to use queue for this
nbsp
force-pushed
the
nbsp/bump/ffi-v0.10.2
branch
from
baedd5e
to
23511a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.