Allowing subscription settings to update before fully subscribed #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
reviewed
Apr 14, 2023
| log("Adaptive stream is enabled, cannot change video track settings", .warning) | ||
| return false | ||
| } | ||
| if !(preferSubscribed || subscribed) { |
There was a problem hiding this comment.
I believe this is no longer true. they should be able to change settings anytime
hiroshihorie
commented
Apr 16, 2023
Comment on lines
200
to
211
| var userCanModifyTrackSettings: Bool { | ||
| // adaptiveStream must be disabled and must be subscribed | ||
| !isAdaptiveStreamEnabled && subscribed | ||
| if kind == .video && isAdaptiveStreamEnabled { | ||
| log("Adaptive stream is enabled, cannot change video track settings", .warning) | ||
| return false | ||
| } | ||
| if !(preferSubscribed || subscribed) { | ||
| log("Cannot update track settings when not subscribed", .warning) | ||
| return false | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
@davidzhao Do you mean this whole check is not required anymore ?
There was a problem hiding this comment.
I just mean the subscribed check. isAdaptiveStreamEnabled is still needed. though re-reading the code, you now have preferSubscribed which actually covers it. sorry about the false alarm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
livekit/client-sdk-js#471
also allow to set videoQuality.