Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: this is just for talking about solutions ... Not to actually merge!!! #195

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ let package = Package(
.package(name: "WebRTC", url: "https://github.com/webrtc-sdk/Specs.git", .exact("104.5112.09")),
.package(name: "SwiftProtobuf", url: "https://github.com/apple/swift-protobuf.git", .upToNextMajor(from: "1.20.2")),
.package(name: "Promises", url: "https://github.com/google/promises.git", .upToNextMajor(from: "2.0.0")),
.package(url: "https://github.com/apple/swift-log.git", .upToNextMajor(from: "1.4.4"))
.package(url: "https://github.com/apple/swift-log.git", .upToNextMajor(from: "1.4.4")),
.package(url: "https://github.com/apple/swift-async-algorithms.git", .upToNextMajor(from: "0.1.0"))
],
targets: [
.systemLibrary(name: "CHeaders"),
Expand All @@ -30,6 +31,7 @@ let package = Package(
.target(name: "CHeaders"),
"WebRTC", "SwiftProtobuf", "Promises",
.product(name: "Logging", package: "swift-log"),
.product(name: "AsyncAlgorithms", package: "swift-async-algorithms")
],
path: "Sources",
swiftSettings: [
Expand Down
133 changes: 133 additions & 0 deletions Sources/LiveKit/Core/DataChannelPair.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,127 @@
import Foundation
import WebRTC
import Promises
import AsyncAlgorithms

class _DataChannelPair {

public enum Errors: Error {
case decodeFailed
}

let target: Livekit_SignalTarget
private let reliableChannel: RTCDataChannelObserver
private let lossyChannel: RTCDataChannelObserver

var onDataPacket: OnDataPacket?
var dataPackets: AsyncStream<Livekit_DataPacket> {
AsyncStream<Livekit_DataPacket> { continuation in
//WIP:
}
}

init(target: Livekit_SignalTarget, reliableChannel: RTCDataChannel? = nil, lossyChannel: RTCDataChannel? = nil) {
self.target = target
self.reliableChannel = RTCDataChannelObserver(channel: reliableChannel)
self.lossyChannel = RTCDataChannelObserver(channel: lossyChannel)
}

public func set(reliable rChannel: RTCDataChannel?, lossy lChannel: RTCDataChannel?) {
self.reliableChannel.channel = rChannel
self.lossyChannel.channel = lChannel
}

public func open() async throws {
await observeChannelStates(expectedReliableChannelState: .open, expectedLossyChannelState: .open)
}

public func close() async {
await withTaskGroup(of: Void.self) { group in
[reliableChannel, lossyChannel].forEach { channel in
group.addTask {
channel.close()
}
}

group.addTask {
await self.observeChannelStates(expectedReliableChannelState: .closed, expectedLossyChannelState: .closed)
}
}
}

private func observeChannelStates(expectedReliableChannelState: RTCDataChannelState, expectedLossyChannelState: RTCDataChannelState) async {
for await (reliableState, lossyState) in combineLatest(reliableChannel.states, lossyChannel.states) {
print("got reliable state: \(reliableState), lossy state: \(lossyState)")
guard reliableState == expectedReliableChannelState, lossyState == expectedLossyChannelState else { continue }
break //terminate asyncsequence
}
}

final class RTCDataChannelObserver: NSObject, RTCDataChannelDelegate {

var channel: RTCDataChannel? {
willSet {
channel?.delegate = nil
}

didSet {
channel?.delegate = self
}
}

private var stateUpdate: ((RTCDataChannelState) -> Void)?
private var messageReceived: ((RTCDataBuffer) -> Void)?

var states: AsyncStream<RTCDataChannelState> {
AsyncStream { continuation in
stateUpdate = { state in
continuation.yield(state)
}

continuation.onTermination = { @Sendable _ in
self.stateUpdate = nil
}
}
}

var messages: AsyncStream<RTCDataBuffer> {
AsyncStream { continuation in
messageReceived = { buffer in
continuation.yield(buffer)
}

continuation.onTermination = { @Sendable _ in
self.messageReceived = nil
}
}
}

init(channel: RTCDataChannel? = nil) {
super.init()
self.channel = channel
}

deinit {
print("DEBUG: deinit \(self)")
}

func close() {
channel?.close()
}

func dataChannelDidChangeState(_ dataChannel: RTCDataChannel) {
assert(dataChannel == channel)
stateUpdate?(dataChannel.readyState)
}

func dataChannel(_ dataChannel: RTCDataChannel, didReceiveMessageWith buffer: RTCDataBuffer) {
assert(dataChannel == channel)
messageReceived?(buffer)
}
}
}

typealias OnDataPacket = (_ dataPacket: Livekit_DataPacket) -> Void

internal class DataChannelPair: NSObject, Loggable {

Expand Down Expand Up @@ -70,6 +191,18 @@ internal class DataChannelPair: NSObject, Loggable {
openCompleter.fulfill(())
}
}

public func set(reliable rChannel: RTCDataChannel?, lossy lChannel: RTCDataChannel?) {
self._reliableChannel = rChannel
rChannel?.delegate = self

self._lossyChannel = lChannel
lChannel?.delegate = self

if isOpen {
openCompleter.fulfill(())
}
}

public func close() -> Promise<Void> {

Expand Down
Loading