Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp README.md #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revamp README.md #133

wants to merge 1 commit into from

Conversation

dsa
Copy link
Member

@dsa dsa commented Sep 8, 2022

Draft pass at an updated readme, giving a bit more structure and reordering some of the information. There are a few areas that need to be fleshed out with more content, but seems like this may be a good starting foundation we can expand upon further.

Draft pass at an updated readme, giving a bit more structure and reordering some of the information. There are a few areas that need to be fleshed out with more content, but seems like this may be a good starting foundation we can expand upon further.
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

LiveKit for Swift is available as a Swift Package.
### Requirements

### Swift Package Manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we now support Cocoapods too, would be great to document steps here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice, yeah, let's do that.

Delegates will be called on the SDK's internal thread.
Make sure any access to the UI is within the main thread, for example by using `DispatchQueue.main.async`.

# Memory management
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are quite useful, and I would place it further down in the details section.

Along with this, it would be good to have a section on how to keep the session running in the background (i.e. project settings, publish audio)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they're useful, I was thinking they could be on the wiki for the repo and perhaps linked to from the main README

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, that works. Just don't want to lose this. Memory management can be tricky for folks that are building real applications. If not careful, would lead to crashes/etc.

## iOS Usage

LiveKit provides an UIKit based `VideoView` class that renders video tracks. Subscribed audio tracks are automatically played.
### Something Simple with SwiftUI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a placeholder title?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be placeholder, or it can be the actual title.


Docs and guides are at [https://docs.livekit.io](https://docs.livekit.io).
<insert gif/image here />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder for now ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, happy to use a video that you record =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants