🐛 [fix] Fix a bug of not-localized Packages-menu and View-menu #303
Conversation
juggernautjp
requested review from
Anonym0uz,
liuderchi,
nerhis,
preco21 and
stsewd
as code owners
| andTheAwesome: "والرائع " | ||
| atomCommunity: "مجتمع أتوم" | ||
| About: | ||
| tabTitle: "عن" |
There was a problem hiding this comment.
Looks like there are some whitespace changes, please help remove these, thanks!
There was a problem hiding this comment.
I am sorry to reply so late. I do not understand the situation, because I have never pushed def/ar/about.cson yet.
And def/ar/about.cson in my local repository is the just the same as that of atom-i18n version 0.25.0, with WinMerge tools.
I noticed that some source code (*.js) and json files used LF as the line separator, and now, use CRLF as it.
So, the files that I pushed as Pull Request use CRLF. Should I push def/ar/about.cson with CRLF?
There was a problem hiding this comment.
@juggernautjp You may just merge the latest main branch and push, to update this PR and resolve conflict.
# update your local main branch
git checkout main
git pull
# update your local PR branch (merge with main)
git checkout add/localize-welcome-views
git merge main --no-edit
# push PR branch
git push
I fixed a bug for the issue #299.