Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #257

wants to merge 2 commits into from

Conversation

Henry2o1o
Copy link
Contributor

No description provided.

@liuderchi liuderchi added the i18n de German translation label Jan 6, 2020
Copy link
Contributor

@polynoman polynoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, two things to remark:

  1. As a german I never heard or read the word "Willkommensanleitung" even though it is clearly german and understandable, it would not be used and is a bit strange to read. If you want to stick with it, I recommend "Willkommensleitfaden".

  2. Willkommens-Guide should be acceptable. Although "Guide" is not originally a german word, it can be found in the Duden https://www.duden.de/rechtschreibung/Guide and normally is understood by german people.

Copy link
Contributor

@polynoman polynoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n de German translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants