Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean changes for JYMA1991/master adding multiple selection feature #94

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yfdyh000
Copy link

https://github.com/jyma1991/listen1_chrome_extension/commits/master
@jyma1991 编写。我去除了格式变更。
Fix #85.

我有看到一个小bug,但其他人好像没有遇到。jyma1991@c7d2be4#comments

@emeryao
Copy link

emeryao commented Sep 20, 2017

兄弟呀 墙不服就服你好吧

@listen1
Copy link
Owner

listen1 commented Dec 19, 2018

抱歉这么久才review,批量操作是非常好的功能,也是一直想要实现却没有实现的功能。
代码中angular部分的代码已经没有问题了,主要是界面设计上可能还觉得可以做的更好一些,可以参考QQ音乐批量操作的交互UI。可以先按批量操作进入批量操作模式后再出现复选框,这样可能会让界面更加简洁些。
感谢PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants