Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage refactor #799

Draft
wants to merge 9 commits into
base: next
Choose a base branch
from
Draft

Storage refactor #799

wants to merge 9 commits into from

Conversation

listen1
Copy link
Owner

@listen1 listen1 commented Feb 24, 2022

What is this PR about

indexed db now is only choice for storage layer, which may cause some problems:

  • get key value pair using indexed has worse performance than get using localstorage
  • one requirement for desktop users is green lite version (which means you can copy-parse directory to use software anywhere), so indexed db storage will replaced with file or sqilte api.

so i'm trying to move all call to indexed db to models directory, by call model member functions. It will seperate business logic from stoarge layer and we can have better control about peresistancy problems.

Progress

  • settings
  • playerlist
  • tracks

@listen1 listen1 marked this pull request as draft February 24, 2022 11:13
refactor: mediaservice
@mikelxk mikelxk mentioned this pull request Jul 17, 2022
@listen1
Copy link
Owner Author

listen1 commented Aug 30, 2022

v3 is delayed for this pr. Because migrate really need so much modification and testing.

For v3 publish in time, I'm consider that avoid migrate in v3, still use v2 storage, which makes it more easy to publish.

So this PR will be paused unless plan changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants