-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout Improvements #755
base: next
Are you sure you want to change the base?
Layout Improvements #755
Conversation
Thanks for so much work delicated to project. By the way, one pr for one feature is recommended. Easier to merge and modify.
Good to go.
Suggstion: Keep same align style for now playing playlist and common playlist.
Good to go. More elegant way to responsive design👍
Question: I notice inline background image uses inline style base64. Will that be performance issue for many images?
This optimaze is necessary. And it's also complicated for design especially in really narrow width screen. I think the layout in narrow screen can be better designed. Or we can limit a min width. Bug: adjust width of screen, play, next, prev button is not clickable.
I'm not sure increase playerbar height is for this requirement. It seems too high in my test environment (compare to height of sidebar entries).
Bug: Seems not working.
Necessary improvement. I think underline style seems a little strange because seldom design use that besides tab bar. Style suggestion: change underline style to radio button or use iOS style (different background for highlight) Style suggestion: change checkbox to button group is harder for users to understand. I recommend to use checkbox and we can change icons to more common checkbox icon as they used in netease/qq application.
Blur area seems too large. Maybe we can refer to netease/qq effect to adjust parameter
Good to go
Good to go
Good to go BTW: I'm not good at design, so these design suggestions are not professional. I think what I can do is find out some style many music player applications are using and try to follow them. It's really hard for me to judge a pretty new style is good for users to understand and use. |
It seem that the setting page will break if I set zoom level to 150%.
The bug only occur when I set auto switch source to true.
I believe it means the blur radius is set too high. |
Fix tsc error Fix Nowplaying page layout Add the new blur effect
This is expected. You screenshot is looks like an ultra-wide window view, so the flex flow is extend horizontal. Refer to this link And I also implement the blur with the experimental |
Didn't figure out any obvious effect. Can you explain more? Co-authored-by: MikeLxk <[email protected]>
Sorry for merge delay. This pr is too big to be merged for one time, especially many modification made and features included. It's beyond my ability to ensure all the things go well after merge. Please submit pr for one feature, or UI adjust, or code refactor. It's easier to test and make further commit. Thank you for your understanding. |
I will try to do cherry-picks. But many reviews and modifications are made, I'm not sure this will work well. |
A batch of layout and UI improvements: