Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cost_per_example implementation for MPDBM #1510

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

cost_per_example implementation for MPDBM #1510

wants to merge 3 commits into from

Conversation

goodfeli
Copy link
Contributor

@goodfeli goodfeli commented May 2, 2015

No description provided.

@lamblin
Copy link
Member

lamblin commented May 2, 2015

It looks like a lot of logic is copy-pasted from the case we wanted the sum. Could you refactor it?
Also, there are no unit tests for these methods, could you add some that check that the sum of the per-example costs is indeed the same as the cost for the whole batch?

@lamblin lamblin self-assigned this May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lamblin lamblin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodfeli @lamblin