Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6881] replace datepicker with flatpicker #5677

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Jul 23, 2024

Describe your changes
Replace the old datepicker with flatpickr and connect the flatpickr instances (if there are multiple ones, e.g. for module phases). Also adds a time-only datepicker to the time field.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk changed the title [6881] replace datepicker with flatpicker WIP:[6881] replace datepicker with flatpicker Jul 23, 2024
@goapunk goapunk requested a review from hom3mad3 July 23, 2024 14:05
@goapunk
Copy link
Contributor Author

goapunk commented Jul 23, 2024

@hom3mad3 this is more of a wip/concept to discuss, maybe you can have a look already before this is going in the wrong direction

@goapunk goapunk requested a review from hom3mad3 July 29, 2024 14:01
@goapunk goapunk changed the title WIP:[6881] replace datepicker with flatpicker [6881] replace datepicker with flatpicker Jul 29, 2024
@hom3mad3
Copy link
Contributor

@goapunk where and how can i test this?

@goapunk
Copy link
Contributor Author

goapunk commented Jul 29, 2024

@goapunk where and how can i test this?

in the dashboard on any module (phases setting), e.g. http://127.0.0.1:8003/dashboard/modules/participatory-budgeting-3-phase-3/phases/

@hom3mad3 hom3mad3 merged commit 0f7a8a4 into main Jul 30, 2024
3 checks passed
@hom3mad3 hom3mad3 deleted the jd-2024-07-flatpickr branch July 30, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants