Add support for NodeBalancers UDP #630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
commented
Nov 22, 2024
Comment on lines
4
to
10
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/jarcoal/httpmock" | ||
| "github.com/linode/linodego" | ||
| "github.com/stretchr/testify/assert" | ||
| "testing" | ||
| ) |
There was a problem hiding this comment.
These changes were made implicitly by gofumpt -l -w .
lgarber-akamai
commented
Nov 22, 2024
Comment on lines
+2
to
+23
| "algorithm": "ring_hash", | ||
| "check": "http_body", | ||
| "check_attempts": 3, | ||
| "check_body": "it works", | ||
| "check_interval": 90, | ||
| "check_path": "/test", | ||
| "check_timeout": 10, | ||
| "cipher_suite": "recommended", | ||
| "id": 4567, | ||
| "nodebalancer_id": 1234, | ||
| "nodes_status": { | ||
| "down": 0, | ||
| "up": 4 | ||
| }, | ||
| "port": 1234, | ||
| "protocol": "udp", | ||
| "ssl_commonname": "www.example.com", | ||
| "ssl_fingerprint": "00:01:02:03:04:05:06:07:08:09:0A:0B:0C:0D:0E:0F:10:11:12:13", | ||
| "ssl_key": "<REDACTED>", | ||
| "stickiness": "source_ip", | ||
| "udp_check_port": 12345, | ||
| "udp_session_timeout": 10 |
There was a problem hiding this comment.
I still need to verify the exact response body for UDP configs, but this should suffice for now 🙂
lgarber-akamai
added
the
do-not-merge
lgarber-akamai
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds support for UDP NodeBalancer configs as well as the corresponding tests.
✔️ How to Test
The following test steps assume you have pulled down this PR locally.
Unit Testing
Integration Testing