[feat] - implement AddressSet CRD and support in firewall controller #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
force-pushed
the
addrset-crd
branch
from
b7fe63e
to
0c44edf
Compare
eljohnson92
reviewed
Nov 26, 2024
| @@ -70,6 +70,9 @@ type FirewallRule struct { | |||
| // +kubebuilder:validation:Enum=TCP;UDP;ICMP;IPENCAP | |||
| Protocol linodego.NetworkProtocol `json:"protocol"` | |||
| Addresses *NetworkAddresses `json:"addresses"` | |||
| // AddressSetRefs is a list of references to AddressSets | |||
| // If Addresses is present, AddressSetRefs will be ignored | |||
| AddressSetRefs []*corev1.ObjectReference `json:"addressSetRefs,omitempty"` | |||
There was a problem hiding this comment.
do these have to be mutually exclusive or could we do both?
There was a problem hiding this comment.
We could do both if it's less confusing
AshleyDumaine
force-pushed
the
addrset-crd
branch
2 times, most recently
from
d7c494e
to
05cd652
Compare
AshleyDumaine
force-pushed
the
addrset-crd
branch
from
05cd652
to
cce15ff
Compare
AshleyDumaine
force-pushed
the
addrset-crd
branch
from
3709d73
to
2c0ae82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds a new CRD that can be reused to construct LinodeFirewalls in case addresses are common between firewalls (e.g. common allowed hosts for control plane and worker node Firewalls)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: