Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] : use fixed retryAfter instead of exponential backoff #576

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

rahulait
Copy link
Collaborator

What this PR does / why we need it:
We would like to use fixed backoff than exponential as exponential starts with microseconds and makes 10+ requests before it reaches 10 sec or higher backoff time. Since POST calls to /v4/linode/instances have low limits, we would like to make sure we don't make too many POST calls in case of an error due to exponential backoff. With this fix, we are now retrying at a fixed interval. This also affects other calls which use the same method to calculate how soon it should retry, but having a fixed interval for them is also fine.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@rahulait rahulait merged commit 1134d10 into main Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants