Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] respect vlan interface if defined in linodemachine #562

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

AshleyDumaine
Copy link
Member

What this PR does / why we need it: Currently we can't define the VLAN interface to be on something other than eth0. This respects what VLAN interface is defined in the LinodeMachine if any.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@github-actions github-actions bot added the bugfix label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (53f8af3) to head (565c74a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
controller/linodemachine_controller_helpers.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   64.99%   64.85%   -0.14%     
==========================================
  Files          79       79              
  Lines        5656     5663       +7     
==========================================
- Hits         3676     3673       -3     
- Misses       1708     1717       +9     
- Partials      272      273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AshleyDumaine AshleyDumaine merged commit d614afa into main Nov 5, 2024
12 of 13 checks passed
@AshleyDumaine AshleyDumaine deleted the vlan-iface branch November 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants