Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] adding vpcref to linodemachine #553

Merged
merged 6 commits into from
Oct 29, 2024
Merged

[feat] adding vpcref to linodemachine #553

merged 6 commits into from
Oct 29, 2024

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Oct 25, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 86.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.94%. Comparing base (8684d43) to head (4923e0d).

Files with missing lines Patch % Lines
controller/linodemachine_controller.go 81.81% 4 Missing and 2 partials ⚠️
controller/linodemachine_controller_helpers.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   64.76%   64.94%   +0.17%     
==========================================
  Files          79       79              
  Lines        5583     5625      +42     
==========================================
+ Hits         3616     3653      +37     
- Misses       1694     1697       +3     
- Partials      273      275       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komer3 komer3 marked this pull request as ready for review October 28, 2024 14:10
@komer3 komer3 merged commit 12ba433 into main Oct 29, 2024
11 checks passed
@komer3 komer3 deleted the linodemachine-vpcref branch October 29, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants