Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : pin kubebuilder to v4.2.0 and fix controller-gen #549

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Oct 24, 2024

What this PR does / why we need it:
make build was failing on the main branch when code was checked out into a new directory and devbox shell was invoked.

abc@vm:~$ git clone [email protected]:linode/cluster-api-provider-linode.git test-code
Cloning into 'test-code'...
remote: Enumerating objects: 6821, done.
remote: Counting objects: 100% (1206/1206), done.
remote: Compressing objects: 100% (730/730), done.
remote: Total 6821 (delta 733), reused 750 (delta 431), pack-reused 5615 (from 1)
Receiving objects: 100% (6821/6821), 12.12 MiB | 23.03 MiB/s, done.
Resolving deltas: 100% (4456/4456), done.
abc@vm:~$ cd test-code/
abc@vm:~/test-code$ devbox install
Info: Ensuring packages are installed.
✓ Computed the Devbox environment.
Finished installing packages.
abc@vm:~/test-code$ devbox shell
Starting a devbox shell...
(devbox) abc@vm:~/test-code$ make build
/home/abc/test-code/.devbox/nix/profile/default/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
Error: unknown option "rbac:roleName=manager-role"
Usage:
  controller-gen [flags]

Flags:
  -h, --help   help for controller-gen
run `controller-gen rbac:roleName=manager-role crd webhook paths=./... output:crd:artifacts:config=config/crd/bases -w` to see all available markers, or `controller-gen rbac:roleName=manager-role crd webhook paths=./... output:crd:artifacts:config=config/crd/bases -h` for usage
make: *** [Makefile:85: generate-manifests] Error 1
(devbox) abc@vm:~/test-code$

This PR fixes the issues and also pins kubebuilder to v4.2.0 as there is a breaking change in v4.3.0
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.78%. Comparing base (80572d0) to head (8a830ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   63.78%   63.78%           
=======================================
  Files          79       79           
  Lines        5575     5575           
=======================================
  Hits         3556     3556           
  Misses       1738     1738           
  Partials      281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait merged commit 46f32f5 into main Oct 24, 2024
13 checks passed
@rahulait rahulait deleted the fix-devbox branch October 24, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants