Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use retryAfter() instead of static 10 sec delay for optimized POST call timing #547

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Oct 23, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (2c91eb4) to head (5e5ca4f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
controller/linodemachine_controller_helpers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   64.82%   63.78%   -1.05%     
==========================================
  Files          79       79              
  Lines        4299     5575    +1276     
==========================================
+ Hits         2787     3556     +769     
- Misses       1242     1738     +496     
- Partials      270      281      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komer3 komer3 merged commit 80572d0 into main Oct 23, 2024
11 of 13 checks passed
@komer3 komer3 deleted the retry-on-postcall branch October 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants