-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement] Add env var toggle for gzip compression of cloud-init user data #531
Conversation
2c5f6f4
to
47eeb85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
- Coverage 64.85% 64.59% -0.27%
==========================================
Files 79 79
Lines 5663 5689 +26
==========================================
+ Hits 3673 3675 +2
- Misses 1717 1740 +23
- Partials 273 274 +1 ☔ View full report in Codecov by Sentry. |
@@ -160,39 +168,6 @@ func TestSetUserData(t *testing.T) { | |||
}}, nil) | |||
}, | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw I think this is still a valid test case, I hope we don't hit it often but userdata can be too large still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair, just need to figure out how to make data that gzips to more than 16kB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could decrease the limit for the sake of the test to validate a smaller gzip gets rejected? not sure if that would require too much refactoring to handle
a1974cd
to
a6fb807
Compare
a6fb807
to
4b322bd
Compare
7bf629a
to
9eccd2b
Compare
ab2fc37
to
af47b96
Compare
af47b96
to
1c282da
Compare
1c282da
to
c4b48fa
Compare
NOTE: Using this toggle requires using OS images with an updated cloud-init version (>24.3.1)
What this PR does / why we need it: This adds support for gzipping the userData before base64 encoding it so we can fit more configuration into cloud-init.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: