Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out e2e tests into its own gha file #301

Merged
merged 3 commits into from
May 3, 2024
Merged

split out e2e tests into its own gha file #301

merged 3 commits into from
May 3, 2024

Conversation

eljohnson92
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.87%. Comparing base (2f81203) to head (1782fe3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   64.40%   64.87%   +0.47%     
==========================================
  Files          30       30              
  Lines        1750     1842      +92     
==========================================
+ Hits         1127     1195      +68     
- Misses        574      592      +18     
- Partials       49       55       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 force-pushed the gha-refactor branch 13 times, most recently from 137ab2b to e9700bc Compare May 2, 2024 20:21
komer3
komer3 previously approved these changes May 3, 2024
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Makefile Show resolved Hide resolved
@eljohnson92 eljohnson92 merged commit 0ff8a1c into main May 3, 2024
10 checks passed
@eljohnson92 eljohnson92 deleted the gha-refactor branch May 3, 2024 16:10
amold1 pushed a commit that referenced this pull request May 17, 2024
* split out e2e tests into its own gha file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants