Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a separate workflow for go analyze #286

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

eljohnson92
Copy link
Collaborator

@eljohnson92 eljohnson92 commented Apr 24, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This moves the code to do static code analysis into it's own workflow file. This also removes the security/vuln checks as the codeql settings on the repo should also cover that

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.42%. Comparing base (3ff0933) to head (9db3136).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   54.42%   54.42%           
=======================================
  Files          27       27           
  Lines        1560     1560           
=======================================
  Hits          849      849           
  Misses        663      663           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 force-pushed the separate-go-analyse branch 2 times, most recently from 5ead69f to b90691e Compare April 24, 2024 21:16
@eljohnson92 eljohnson92 changed the title create a separate workflow for go analyse create a separate workflow for go analyze Apr 24, 2024
@linode linode deleted a comment from github-advanced-security bot Apr 25, 2024
@eljohnson92 eljohnson92 merged commit e518023 into main Apr 25, 2024
9 checks passed
@eljohnson92 eljohnson92 deleted the separate-go-analyse branch April 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants