add unittests for linodevpc_controller #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulait
force-pushed
the
vpc_controller_unittests
branch
from
14a4e5b
to
346a4e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 60.57% 64.40% +3.82%
==========================================
Files 30 30
Lines 1750 1750
==========================================
+ Hits 1060 1127 +67
+ Misses 644 574 -70
- Partials 46 49 +3 ☔ View full report in Codecov by Sentry. |
bcm820
previously approved these changes
Apr 25, 2024
rahulait
force-pushed
the
vpc_controller_unittests
branch
from
346a4e6
to
3e06a0b
Compare
rahulait
force-pushed
the
vpc_controller_unittests
branch
from
3e06a0b
to
3ca0413
Compare
eljohnson92
approved these changes
Apr 30, 2024
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
* add unittests for vpc_controller * rebase and fix lint errors --------- Co-authored-by: Rahul Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds more unit tests for controller/linodevpc_controller.go to increase code coverage
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: