Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt linodecluster controller tests to new mocktest changes #277

Merged
merged 43 commits into from
Apr 26, 2024

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Apr 23, 2024

What type of PR is this?
adapt linodecluster controller tests to new mocktest changes

/kind testing

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@amold1 amold1 requested a review from bcm820 April 23, 2024 11:59
@amold1 amold1 force-pushed the mocktest.adeodhar branch 2 times, most recently from b306c42 to b340071 Compare April 23, 2024 12:02
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.57%. Comparing base (75c6a5d) to head (1dc5f24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   59.34%   60.57%   +1.22%     
==========================================
  Files          30       30              
  Lines        1749     1750       +1     
==========================================
+ Hits         1038     1060      +22     
+ Misses        663      644      -19     
+ Partials       48       46       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amold1 amold1 force-pushed the mocktest.adeodhar branch 2 times, most recently from 981da38 to 5189433 Compare April 26, 2024 13:36
bcm820
bcm820 previously approved these changes Apr 26, 2024
Base automatically changed from mocktest to main April 26, 2024 15:41
@bcm820 bcm820 dismissed their stale review April 26, 2024 15:41

The base branch was changed.

@amold1 amold1 requested a review from bcm820 April 26, 2024 15:56
@amold1 amold1 merged commit 4e12116 into main Apr 26, 2024
9 checks passed
@amold1 amold1 deleted the mocktest.adeodhar branch May 3, 2024 18:20
amold1 added a commit that referenced this pull request May 17, 2024
* adapt linodecluster controller tests to new mocktest changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants