-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an E2E test that runs a full CAPL cluster test (default, k3s, & rke2) on merging to main #266
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 64.40% 64.40%
=======================================
Files 30 30
Lines 1750 1750
=======================================
Hits 1127 1127
Misses 574 574
Partials 49 49 ☔ View full report in Codecov by Sentry. |
This reverts commit eb52636.
Makefile
Outdated
GIT_REF=$(GIT_REF) $(CHAINSAW) test ./e2e | ||
e2etest: generate local-release local-deploy chainsaw | ||
ifeq ($(strip $(E2E_FLAGS)),) ## If E2E_FLAGS not set, run quick e2e tests | ||
GIT_REF=$(GIT_REF) $(CHAINSAW) test ./e2e --selector quick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given we are always including the selector here, can we maybe have --selector ${E2E_SELECTOR} ${E2E_FLAGS}
and do the switches in GHA?
There's quite a lot of duplication where we have multiple files creating the same resources in different directories. I'll try to refactor this so we have all of them in one place along with the |
…& rke2) on merging to main (#266) * adeodhar: add try catch block --------- Co-authored-by: Khaja Omer <[email protected]> Co-authored-by: Amol Deodhar <[email protected]>
What type of PR is this?
/kind testing
What this PR does / why we need it:
This PR contains the following changes:
--selector LABEL
flag (check testing docs for more detail)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: