Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an E2E test that runs a full CAPL cluster test (default, k3s, & rke2) on merging to main #266

Merged
merged 54 commits into from
May 1, 2024

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Apr 18, 2024

What type of PR is this?
/kind testing

What this PR does / why we need it:
This PR contains the following changes:

  • New e2e tests for 3 flavors default, k3s, and rke2
  • New feature to allow selecting specific e2e tests using --selector LABEL flag (check testing docs for more detail)
  • A complete e2e test (All the e2e test) that runs when a PR is merged into the main branch
  • Adding some catch blocks for debugging

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.40%. Comparing base (1af26a0) to head (f6425ba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   64.40%   64.40%           
=======================================
  Files          30       30           
  Lines        1750     1750           
=======================================
  Hits         1127     1127           
  Misses        574      574           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komer3 komer3 changed the title Adding more a complete E2E test that only runs when a PR is merged to main Adding an E2E test that runs a full CAPL cluster on merging to main Apr 22, 2024
@komer3 komer3 marked this pull request as ready for review April 22, 2024 18:45
Makefile Outdated Show resolved Hide resolved
@komer3 komer3 changed the title Adding an E2E test that runs a full CAPL cluster on merging to main Adding an E2E test that runs a full CAPL cluster test (default, k3s, & rke2) on merging to main Apr 26, 2024
Makefile Outdated
GIT_REF=$(GIT_REF) $(CHAINSAW) test ./e2e
e2etest: generate local-release local-deploy chainsaw
ifeq ($(strip $(E2E_FLAGS)),) ## If E2E_FLAGS not set, run quick e2e tests
GIT_REF=$(GIT_REF) $(CHAINSAW) test ./e2e --selector quick
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given we are always including the selector here, can we maybe have --selector ${E2E_SELECTOR} ${E2E_FLAGS} and do the switches in GHA?

@amold1
Copy link
Contributor

amold1 commented Apr 30, 2024

There's quite a lot of duplication where we have multiple files creating the same resources in different directories. I'll try to refactor this so we have all of them in one place along with the try..catch blocks.

@komer3 komer3 merged commit 0357041 into main May 1, 2024
10 checks passed
@komer3 komer3 deleted the main-merge-e2e branch May 1, 2024 14:52
amold1 added a commit that referenced this pull request May 17, 2024
…& rke2) on merging to main (#266)


* adeodhar: add try catch block

---------

Co-authored-by: Khaja Omer <[email protected]>
Co-authored-by: Amol Deodhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants