Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize k8s version and common setup steps in templates #259

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

eljohnson92
Copy link
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR does some cleanup of our templates in a few ways

  • executes common steps such as turning swap off in a consistent way across flavors
  • removes providerID specification since the CCM can handle setting this correctly when it is installed
  • sets all flavors to use the KUBERNETES_VERSION env variable so the clusterctl --kubernetes-version flag will work as expected

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@AshleyDumaine AshleyDumaine added the cleanup anything cleanup related label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.83%. Comparing base (fa66dc0) to head (9c975b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   53.83%   53.83%           
=======================================
  Files          27       27           
  Lines        1566     1566           
=======================================
  Hits          843      843           
  Misses        673      673           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, gave it a go on the RKE2 and default flavors and works fine 👍

@eljohnson92 eljohnson92 merged commit 1b0a785 into main Apr 17, 2024
8 checks passed
@eljohnson92 eljohnson92 deleted the cleanup_templates branch April 17, 2024 19:48
AshleyDumaine pushed a commit that referenced this pull request Apr 19, 2024
* standardize k8s version and common setup steps in templates
amold1 pushed a commit that referenced this pull request May 17, 2024
* standardize k8s version and common setup steps in templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup anything cleanup related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants