[feat] - add new etcd-disk flavor #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
force-pushed
the
etcd-disk-flavor
branch
3 times, most recently
from
ac904f3
to
2bda4bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 53.83% 53.83%
=======================================
Files 27 27
Lines 1566 1566
=======================================
Hits 843 843
Misses 673 673
Partials 50 50 ☔ View full report in Codecov by Sentry. |
eljohnson92
reviewed
Apr 17, 2024
eljohnson92
reviewed
Apr 17, 2024
| local: | ||
| dataDir: /var/lib/etcd_data/etcd | ||
| extraArgs: | ||
| quota-backend-bytes: "8589934592" |
There was a problem hiding this comment.
do we still need this section if it is in the default flavor?
There was a problem hiding this comment.
We technically don't but I wanted to leave it in for clarity. I'm fine with removing it
AshleyDumaine
force-pushed
the
etcd-disk-flavor
branch
2 times, most recently
from
3375f17
to
b54ac50
Compare
AshleyDumaine
added
documentation
AshleyDumaine
force-pushed
the
etcd-disk-flavor
branch
from
b54ac50
to
a8cd5bc
Compare
eljohnson92
approved these changes
Apr 17, 2024
AshleyDumaine
added a commit
that referenced
this pull request
Apr 19, 2024
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it: This creates a new flavor to configure etcd to be on a separate disk
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: