Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mocktest module #255

Merged
merged 32 commits into from
Apr 26, 2024
Merged

Add mocktest module #255

merged 32 commits into from
Apr 26, 2024

Conversation

bcm820
Copy link
Contributor

@bcm820 bcm820 commented Apr 15, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@bcm820 bcm820 added go Pull requests that update Go code testing Pull requests that improve tests labels Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 59.34%. Comparing base (44f565f) to head (56ac277).

Files Patch % Lines
cmd/main.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   54.21%   59.34%   +5.13%     
==========================================
  Files          27       30       +3     
  Lines        1577     1749     +172     
==========================================
+ Hits          855     1038     +183     
+ Misses        671      663       -8     
+ Partials       51       48       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcm820 bcm820 marked this pull request as ready for review April 24, 2024 20:27
@bcm820 bcm820 merged commit 75c6a5d into main Apr 26, 2024
11 checks passed
@bcm820 bcm820 deleted the mocktest branch April 26, 2024 15:41
amold1 pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code testing Pull requests that improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants