[feat] Create new dual-stack flavor #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 50.56% 50.56%
=======================================
Files 27 27
Lines 1493 1493
=======================================
Hits 755 755
Misses 705 705
Partials 33 33 ☔ View full report in Codecov by Sentry. |
AshleyDumaine
added
feature
AshleyDumaine
force-pushed
the
dual-stack
branch
4 times, most recently
from
6c62766
to
5fea2bf
Compare
eljohnson92
reviewed
Apr 8, 2024
AshleyDumaine
force-pushed
the
dual-stack
branch
from
5fea2bf
to
dda4a71
Compare
rahulait
previously approved these changes
Apr 10, 2024
rahulait
reviewed
Apr 10, 2024
AshleyDumaine
force-pushed
the
dual-stack
branch
from
dda4a71
to
d4576ae
Compare
rahulait
approved these changes
Apr 10, 2024
eljohnson92
approved these changes
Apr 10, 2024
AshleyDumaine
added a commit
that referenced
this pull request
Apr 19, 2024
* create new dual-stack flavor * add dual-stack flavor doc, formatting
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
* create new dual-stack flavor * add dual-stack flavor doc, formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it: Adds a new dual-stack flavor to enable ipv6 in kubeadm clusters. Also creates a different ipv6 HelmChartProxy for cilium since enabling ipv6 on cilium without the correct kubeadm settings to support ipv6 will keep cilium from starting properly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: