Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: actions: get setup-go version from go.mod #170

Closed
wants to merge 2 commits into from
Closed

Conversation

cbzzz
Copy link
Contributor

@cbzzz cbzzz commented Mar 6, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Updates setup-go to get the Go version from the go.mod file when running Github Actions.

See: https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Updates setup-go to get the Go version from the go.mod file when running Github Actions.
@AshleyDumaine AshleyDumaine added github_actions Pull requests that update GitHub Actions code cleanup anything cleanup related labels Mar 7, 2024
Copy link
Member

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AshleyDumaine
Copy link
Member

AshleyDumaine commented Mar 7, 2024

Actually looks like #167 does this change as well, I'm open to either merging this or waiting til that is merged since @nesv already approved it

@eljohnson92
Copy link
Collaborator

I just merged in my PR so I think we can close this one out

@cbzzz cbzzz force-pushed the chore.gha.go branch 2 times, most recently from de2815b to e3e00bd Compare March 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup anything cleanup related github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants