Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates related to new keycloak version #86

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Conversation

Ani1357
Copy link
Collaborator

@Ani1357 Ani1357 commented Sep 22, 2023

Renamed the KEYCLOAK_ADDRESS to KC_HOSTNAME as per new version of keycloak.

.env.sample Outdated Show resolved Hide resolved
@ElderMatt
Copy link
Contributor

ElderMatt commented Sep 25, 2023

Previously the SSO tokens were set to 8hours but this is not the case anymore. This happened in keycloak.ts on line 107 - 110.
image
image

@ElderMatt ElderMatt self-requested a review September 25, 2023 10:09
Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you get the SSO session back to 8hours again, we had this as a bandage for a timeout bug.

@ElderMatt
Copy link
Contributor

At the moment Teams/groups are not automatically added in keycloak. This happens in keycloak.ts, search for 'create groups' then you will find it.

@Ani1357
Copy link
Collaborator Author

Ani1357 commented Sep 25, 2023

@ElderMatt you are checking the master realm in keycloak instead of otomi. Tested again and teams are being added as expected and also the correct TTL for the SSO is there.

@j-zimnowoda j-zimnowoda merged commit ef7aff7 into main Sep 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants