Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user management #118

Merged
merged 25 commits into from
Oct 14, 2024
Merged

feat: user management #118

merged 25 commits into from
Oct 14, 2024

Conversation

ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Sep 30, 2024

Implements

https://jira.linode.com/browse/APL-27
https://jira.linode.com/browse/APL-227
https://jira.linode.com/browse/APL-229

Description

This PR adds user management functions in order to create-update-delete users in keycloak and updates keycloak operator.

Is paired with:
Console => https://github.com/linode/apl-console/pull/441
Api => https://github.com/linode/apl-api/pull/565
Core => linode/apl-core#1740

@ferruhcihan ferruhcihan requested review from ElderMatt and CasLubbers and removed request for ElderMatt and CasLubbers September 30, 2024 14:50
@ferruhcihan ferruhcihan marked this pull request as draft October 1, 2024 12:38
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark

src/validators.ts Show resolved Hide resolved
@ferruhcihan ferruhcihan marked this pull request as ready for review October 2, 2024 13:20
src/operator/keycloak.ts Outdated Show resolved Hide resolved
src/operator/keycloak.ts Outdated Show resolved Hide resolved
src/operator/keycloak.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing I released that I had to add manually platform-admin group to the existing Otomi-admin user.
image

@j-zimnowoda j-zimnowoda self-requested a review October 10, 2024 14:18
@j-zimnowoda j-zimnowoda merged commit d086529 into main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants