Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list tag in Dynamic_Discovery.html #921

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

RonWang
Copy link

@RonWang RonWang commented Jul 8, 2023

Currently the page is not displaying the list

When getClient is called on the simple load balancer, it: <ul> <li>First tries to extract the service name from the URI that was provided. </li> <li> It then makes sure that it’s listening to that service in the LoadBalancerState. </li> <li> It then makes sure that it’s listening to the service’s cluster in the LoadBalancerState </li> <li> If either the service or cluster is unknown, it will throw a ServiceUnavailableException. </li> <li> It will then iterate through the prioritized schemes (prpc, http, etc) for the cluster. </li> <li> For each scheme, it will get all URIs in the service’s cluster for that scheme, and ask the service’s load balancer strategy to load balance them.</li> <li> If the load balancer strategy returns a client, it will be returned, otherwise the next scheme will be tried.</li> <li>If all schemes are exhausted, and no client was found, a ServiceUnavailableException will be thrown. </li> </ul>

This commit fixes it now:

When getClient is called on the simple load balancer, it:

First tries to extract the service name from the URI that was provided.
It then makes sure that it’s listening to that service in the LoadBalancerState.
It then makes sure that it’s listening to the service’s cluster in the LoadBalancerState
If either the service or cluster is unknown, it will throw a ServiceUnavailableException.
It will then iterate through the prioritized schemes (prpc, http, etc) for the cluster.
For each scheme, it will get all URIs in the service’s cluster for that scheme, and ask the service’s load balancer strategy to load balance them.
If the load balancer strategy returns a client, it will be returned, otherwise the next scheme will be tried.
If all schemes are exhausted, and no client was found, a ServiceUnavailableException will be thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant