Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sized Box: Use a brush for the border #795

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Sized Box: Use a brush for the border #795

merged 1 commit into from
Dec 17, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This allows for a richer appearance by using any valid brush for the border.

@waywardmonkeys
Sized Box: Use a brush for the border
ef95dc6 
This allows for a richer appearance by using any valid brush for
the border.
@waywardmonkeys
Copy link
Contributor Author

I'm not excited about the clone of the brush here (but it would've happened anyway further down). You can' pass &border.brush in Xilem because there's no From<&Brush> for Brush in Peniko (and maybe there should be?).

I'm not sure that any API being Into<Color> makes all that much sense. There isn't a rich selection of types that convert to peniko::Color.

DJMcNab
DJMcNab approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clone is definitely unfortunate for gradients, but should be cheap for solid and images at least.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 17, 2024
Merged via the queue into linebender:main with commit c4d5950 Dec 17, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the brush-for-border branch December 17, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @DJMcNab