Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CI RUST_MIN_VER_PKGS with --workspace --ignore-private. #782

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Dec 11, 2024

The CI RUST_MIN_VER_PKGS configuration variable was meant to track packages that are intended for publishing in order to limit MSRV checks to only those packages. This same goal can be achieved universally without the need for a configuration variable via the --ignore-private cargo-hack option.

The immediate effect on this repo is that xilem_core is no longer part of the MSRV check because it has publish = false. That is fine, because the MSRV check will run just before publishing, triggered by the PR that will remove publish = false, ensuring that the MSRV is accurate before publishing.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both xilem_core and tree-arena will be checked when their corresponding crates are checked anyway, just not exhaustively with all features.

tree_arena/Cargo.toml Show resolved Hide resolved
@xStrom xStrom added this pull request to the merge queue Dec 11, 2024
Merged via the queue into linebender:main with commit 65ecc25 Dec 11, 2024
17 checks passed
@xStrom xStrom deleted the universalmsrv branch December 11, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants