Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use FontWeight as the name #778

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

waywardmonkeys
Copy link
Contributor

Right now, there are uses of Weight from Fontique, TextWeight from Masonry, and FontWeight from Parley.

We should just use a single name.

Right now, there are uses of `Weight` from Fontique, `TextWeight`
from Masonry, and `FontWeight` from Parley.

We should just use a single name.
@waywardmonkeys
Copy link
Contributor Author

This is related to linebender/parley#211

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been a consequence of just doing whatever auto-import works. I've know it's been inconsistent, but sometimes FontWeight just wouldn't become available, so I went with the Weight which would auto-import as expected.

Thanks!

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 9, 2024
Merged via the queue into linebender:main with commit 653e424 Dec 9, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the use-fontweight-name branch December 9, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants