Render one frame before showing the window to avoid flashing #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Dec 9, 2024
masonry/src/event_loop_runner.rs
Outdated
| surface, | ||
| accesskit_adapter: adapter, | ||
| }; | ||
| self.render_root | ||
| .handle_window_event(WindowEvent::Rescale(scale_factor)); | ||
| // Render one frame before showing the window to avoid flashing | ||
| if visible { | ||
| let (scene, _tree_update) = self.render_root.redraw(); |
There was a problem hiding this comment.
Discarding this tree update feels likely to be very bad. We need to at least reason about it
There was a problem hiding this comment.
Yeah, ignoring the tree update could lead to issues. I’ve updated the code to include it, following the approach used in handling the RedrawRequested event. Let me know if it looks good now.
|
I'm not set up to test accessibility on my machine yet. But this looks right to me now. I'm treating this similarly to #767, where it's a targeted fix which shouldn't lead to regressions. |
DJMcNab
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590.
Demo:
