Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect the CI OS detection from the OS version. #776

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Dec 8, 2024

The current matrix.os == 'ubuntu-latest' expression works, but will fail if we for some reason need to switch to explicitly use e.g. ubuntu-24.04. Doing the same check via runner.os == 'Linux' disconnects the check from the specific OS version.

@xStrom xStrom added this pull request to the merge queue Dec 8, 2024
@xStrom xStrom removed this pull request from the merge queue due to a manual request Dec 8, 2024
@xStrom xStrom enabled auto-merge December 8, 2024 16:02
@xStrom xStrom added this pull request to the merge queue Dec 8, 2024
Merged via the queue into linebender:main with commit 9439b55 Dec 8, 2024
17 checks passed
@xStrom xStrom deleted the robustos branch December 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants