Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special case when window is resized to zero #771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PoignardAzur
Copy link
Contributor

@PoignardAzur PoignardAzur commented Dec 5, 2024

There have been reported crashes with Xilem when minimizing an app with Windows 11 (see also linebender/vello#371).

This fix is based on the solution proposed in:

https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/Windows.2011.20minimizing

I've tested it on Linux just enough to confirm it doesn't crash. Haven't tested in on Windows yet, so I'm not sure it actually fixes the crash on minimize.

@xStrom
Copy link
Member

xStrom commented Dec 6, 2024

This fixes the crash, but after restoring the window from the minimized state no events are processed any more. So clicking on buttons, including the X to close window, doesn't do anything.

09:50:39.763Z  WARN Got window event whilst suspended or before window created event=CursorMoved { device_id: DeviceId(DeviceId(0)), position: PhysicalPosition { x: 674.0, y: 1.0 } }
09:50:39.764Z  WARN Got window event whilst suspended or before window created event=CursorMoved { device_id: DeviceId(DeviceId(0)), position: PhysicalPosition { x: 674.0, y: 0.0 } }
09:50:39.770Z  WARN Got window event whilst suspended or before window created event=CursorLeft { device_id: DeviceId(DeviceId(0)) }
09:50:40.083Z  WARN Got window event whilst suspended or before window created event=CloseRequested
09:50:40.661Z  WARN Got window event whilst suspended or before window created event=CloseRequested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants