Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to upstream unbatched PlainEditor #766

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Dec 3, 2024

Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the reduction in code with this PR. I can't find any regressions. Everything works as I'd expect.
Will probably be ready for merge once the parley PR is merged into main and this branch reflects that.

This is linebender/parley#192

Follow-up with docs and line height
@DJMcNab DJMcNab marked this pull request as ready for review December 5, 2024 09:17
@DJMcNab DJMcNab enabled auto-merge December 5, 2024 09:17
@DJMcNab DJMcNab added this pull request to the merge queue Dec 5, 2024
Merged via the queue into linebender:main with commit 5d423cf Dec 5, 2024
17 checks passed
@DJMcNab DJMcNab deleted the editor-driver branch December 5, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants