Restore underline and strikethrough in render_text #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another regression from linebender#754 ...
DJMcNab
commented
Nov 28, 2024
masonry/src/widget/screenshots/masonry__widget__label__tests__strikethrough_label.png
Outdated
Show resolved
Hide resolved
tomcur
reviewed
Nov 28, 2024
dfrg
reviewed
Nov 28, 2024
dfrg
reviewed
Nov 28, 2024
|
I've removed the half-width offset, which has worked. However, I am extremely confused about why it has worked... The only assumption I think I'm making is that the stroked path is the center line of the stroke? Is that perhaps incorrect. |
Oh, I didn't catch that you were using a stroke rather than a rect fill. Yes, strokes are expanded by half-width from the center line. |
|
I have reached a state of greater understanding thanks to #763 (comment) |
tomcur
reviewed
Nov 28, 2024
Co-authored-by: Tom Churchman <[email protected]>
|
I now believe this PR is now finally in a good state. Thanks for all the help both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another regression from #754 ...
Needed for #762