-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic window control #670
Conversation
ce36ad1
to
f5578f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the additional signals; less sure about the new widget
Well, I guess I should've included more information on how the The |
00b7aac
to
bb4d08f
Compare
I still feel that My suggested next step here is to make this PR only the changes required to allow creating this |
bb4d08f
to
1507990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, this slipped out of my queue. This looks great, thanks.
Luckily, no merge conflicts seem to have arisen in the intervening period. Let's hope that's also true for CI :)
This is the first merge-able part of #606.
It allows to implement custom CSDs via window management signals and a new
WindowHandle
widget which is useful to implement a custom titlebar.