Stop storing text in TextLayout #666
Conversation
Remove type parameter from TextLayout. Tweak error message in text widgets. This makes the TextLayout code slightly simpler (though with more invariants) in anticipation of splitting it into its own crate.
|
This is another chunk of work split off from #625. |
| @@ -37,8 +37,7 @@ use crate::text::render_text; | |||
| /// | |||
| /// TODO: Update docs to mentionParley | |||
| #[derive(Clone)] | |||
| pub struct TextLayout<T> { | |||
| text: T, | |||
| pub struct TextLayout { | |||
| // TODO: Find a way to let this use borrowed data | |||
There was a problem hiding this comment.
Is this comment still accurate?
There was a problem hiding this comment.
If you mean the "use borrowed data" comment, yes, it's still accurate.
It's from this commit: 732cfa8#diff-da6cde61a550125d612ef93c9aecd16c1210e2cfbfb664d3ba0a9ab00ddc2caf
Not sure what it means either. @DJMcNab ?
There was a problem hiding this comment.
I have no idea. It seems you understand this comment better than me - because I assume that it applied to the text field and was misplaced.
There was a problem hiding this comment.
We'll remove it then.
|
I'm curious if this has any bearing on changing from just displaying text of a single run of size + color to being able to do richer text via a builder or something. |
I don't think it does. |
Fixed. |
| @@ -37,8 +37,7 @@ use crate::text::render_text; | |||
| /// | |||
| /// TODO: Update docs to mentionParley | |||
| #[derive(Clone)] | |||
| pub struct TextLayout<T> { | |||
| text: T, | |||
| pub struct TextLayout { | |||
| // TODO: Find a way to let this use borrowed data | |||
There was a problem hiding this comment.
I have no idea. It seems you understand this comment better than me - because I assume that it applied to the text field and was misplaced.
See discussion in #666
Remove type parameter from TextLayout.
Tweak error message in text widgets.
This makes the TextLayout code slightly simpler (though with more invariants) in anticipation of splitting it into its own crate.