Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic at Option::unwrap in App::accessibility #138

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix panic at Option::unwrap in App::accessibility #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ where

pub fn accessibility(&mut self) -> TreeUpdate {
let mut update = TreeUpdate::default();
self.ensure_root();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small thought (not relevant to this PR) - should Glazier be handling this instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I'm not deep enough in the codebase currently to provide good input (especially in glazier), maybe someone else should investigate (still not really in the best situation to code right now)

let root_pod = self.root_pod.as_mut().unwrap();
let mut window_node_builder = accesskit::NodeBuilder::new(accesskit::Role::Window);
window_node_builder.set_name("xilem window");
Expand Down