Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feerate_floor and feerates object to estimatefees method. #577

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

ca-ruz
Copy link
Contributor

@ca-ruz ca-ruz commented Jul 27, 2024

Fixes #458.

@iorch
Copy link

iorch commented Aug 21, 2024

With the version in lightningd:master I get this error:

lightningd --mainnet --disable-plugin bcli --sauron-api-endpoint https://blockstream.info/api/
2024-08-21T20:15:29.707Z INFO    lightningd: v24.05-modded
2024-08-21T20:15:29.765Z INFO    plugin-manager: /usr/local/libexec/c-lightning/plugins/bcli: disabled via disable-plugin
2024-08-21T20:15:30.029Z INFO    plugin-sauron.py: RPC method 'getchaininfo' does not have a docstring.
2024-08-21T20:15:30.030Z INFO    plugin-sauron.py: RPC method 'getrawblockbyheight' does not have a docstring.
2024-08-21T20:15:30.030Z INFO    plugin-sauron.py: RPC method 'sendrawtransaction' does not have a docstring.
2024-08-21T20:15:30.030Z INFO    plugin-sauron.py: RPC method 'getutxout' does not have a docstring.
2024-08-21T20:15:30.030Z INFO    plugin-sauron.py: RPC method 'estimatefees' does not have a docstring.
2024-08-21T20:15:30.356Z INFO    plugin-sauron.py: Sauron plugin initialized
2024-08-21T20:15:30.356Z INFO    plugin-sauron.py: 
2024-08-21T20:15:30.356Z INFO    plugin-sauron.py: 
2024-08-21T20:15:30.356Z INFO    plugin-sauron.py:                      Three::rings
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:                 for:::the::Elven-Kings
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:              under:the:sky,:Seven:for:the
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:            Dwarf-Lords::in::their::halls:of
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:           stone,:Nine             for:Mortal
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:          :::Men:::     ________     doomed::to
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:        die.:One   _,-'...:... `-.    for:::the
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:        ::Dark::  ,- .:::::::::::. `.   Lord::on
2024-08-21T20:15:30.357Z INFO    plugin-sauron.py:       his:dark ,'  .:::::zzz:::::.  `.  :throne:
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:       In:::the/    ::::dMMMMMb::::    \\ Land::of
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:       :Mordor:\\    ::::dMMmgJP::::    / :where::
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:       ::the::: '.  '::::YMMMP::::'  ,'  Shadows:
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:        lie.::One  `. ``:::::::::'' ,'    Ring::to
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:        ::rule::    `-._```:'''_,-'     ::them::
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:        all,::One      `-----'        ring::to
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:          ::find:::                  them,:One
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:           Ring:::::to            bring::them
2024-08-21T20:15:30.358Z INFO    plugin-sauron.py:             all::and::in:the:darkness:bind
2024-08-21T20:15:30.359Z INFO    plugin-sauron.py:               them:In:the:Land:of:Mordor
2024-08-21T20:15:30.359Z INFO    plugin-sauron.py:                  where:::the::Shadows
2024-08-21T20:15:30.359Z INFO    plugin-sauron.py:                       :::lie.:::
2024-08-21T20:15:30.359Z INFO    plugin-sauron.py: 
2024-08-21T20:15:30.359Z INFO    plugin-sauron.py: 
2024-08-21T20:15:30.857Z **BROKEN** lightningd: DEPRECATED API USED estimatefeesv1 
2024-08-21T20:15:34.447Z INFO    lightningd: --------------------------------------------------
2024-08-21T20:15:34.447Z INFO    lightningd: Server started with public key 039f2ade0a0b8d96bbf1f867b866415104e07ad184d906665624612a5557a56f25, alias PEEVEDSOUFFLE (color #039f2a) and lightningd v24.05-modded
2024-08-21T20:16:01.009Z **BROKEN** lightningd: DEPRECATED API USED estimatefeesv1 
2024-08-21T20:16:32.618Z **BROKEN** lightningd: DEPRECATED API USED estimatefeesv1 
2024-08-21T20:17:02.764Z **BROKEN** lightningd: DEPRECATED API USED estimatefeesv1 

After the changes it seems to work:

$lightningd --mainnet --disable-plugin bcli --sauron-api-endpoint https://blockstream.info/api/
2024-08-21T19:31:07.554Z INFO    lightningd: v24.05-modded
2024-08-21T19:31:07.579Z INFO    plugin-manager: /usr/local/libexec/c-lightning/plugins/bcli: disabled via disable-plugin
2024-08-21T19:31:07.842Z INFO    plugin-sauron.py: RPC method 'getchaininfo' does not have a docstring.
2024-08-21T19:31:07.842Z INFO    plugin-sauron.py: RPC method 'getrawblockbyheight' does not have a docstring.
2024-08-21T19:31:07.842Z INFO    plugin-sauron.py: RPC method 'sendrawtransaction' does not have a docstring.
2024-08-21T19:31:07.842Z INFO    plugin-sauron.py: RPC method 'getutxout' does not have a docstring.
2024-08-21T19:31:07.842Z INFO    plugin-sauron.py: RPC method 'estimatefees' does not have a docstring.
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py: Sauron plugin initialized
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py: 
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py: 
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:                      Three::rings
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:                 for:::the::Elven-Kings
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:              under:the:sky,:Seven:for:the
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:            Dwarf-Lords::in::their::halls:of
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:           stone,:Nine             for:Mortal
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:          :::Men:::     ________     doomed::to
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:        die.:One   _,-'...:... `-.    for:::the
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:        ::Dark::  ,- .:::::::::::. `.   Lord::on
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:       his:dark ,'  .:::::zzz:::::.  `.  :throne:
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:       In:::the/    ::::dMMMMMb::::    \\ Land::of
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:       :Mordor:\\    ::::dMMmgJP::::    / :where::
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:       ::the::: '.  '::::YMMMP::::'  ,'  Shadows:
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:        lie.::One  `. ``:::::::::'' ,'    Ring::to
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:        ::rule::    `-._```:'''_,-'     ::them::
2024-08-21T19:31:08.196Z INFO    plugin-sauron.py:        all,::One      `-----'        ring::to
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py:          ::find:::                  them,:One
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py:           Ring:::::to            bring::them
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py:             all::and::in:the:darkness:bind
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py:               them:In:the:Land:of:Mordor
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py:                  where:::the::Shadows
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py:                       :::lie.:::
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py: 
2024-08-21T19:31:08.197Z INFO    plugin-sauron.py: 
2024-08-21T19:31:10.794Z INFO    lightningd: --------------------------------------------------
2024-08-21T19:31:10.794Z INFO    lightningd: Server started with public key 039f2ade0a0b8d96bbf1f867b866415104e07ad184d906665624612a5557a56f25, alias PEEVEDSOUFFLE (color #039f2a) and lightningd v24.05-modded

I couldn't make it work on signet.

@chrisguida
Copy link
Collaborator

Thanks for testing @iorch !!

And thanks for the excellent PR @ca-ruz !

ACK 6038170

@chrisguida chrisguida merged commit 39ef72f into lightningd:master Aug 21, 2024
7 checks passed
@chrisguida
Copy link
Collaborator

chrisguida commented Aug 21, 2024

@iorch no, sauron does not support mutinynet ot signet at the moment. I don't know of an esplora API for signet, but mutinynet.com has a great esplora API for mutinynet. If you wanted to add mutinynet support to sauron that would be amazing :D

@ca-ruz ca-ruz deleted the sauron-fix-estimatefees branch September 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sauron: estimatefees has changed in CLN version v23.05
3 participants